Skip to content

target 34,35 대응 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
unam98 merged 1 commit into from
Aug 25, 2025
Merged

target 34,35 대응 #362

unam98 merged 1 commit into from
Aug 25, 2025

Conversation

@unam98
Copy link
Collaborator

@unam98 unam98 commented Aug 25, 2025 •
edited by coderabbitai bot
Loading

설명

Android 14 (API 34) 및 Android 15 (API 35) 정책 준수를 위한 종합적인 업데이트

• SDK 업데이트: compileSdk 및 targetSdk를 35로 업그레이드
• Edge-to-Edge 지원: 모든 Activity에 전체화면 모드 적용
• 권한 정책 대응: API 34/35 신규 권한 및 조건부 권한 설정
• Foreground Service 강화: 위치 서비스 타입 명시 및 API 35 제약 대응
• 네트워킹 보안: TLS 1.2+ 강제 적용으로 통신 보안 강화
• Background Activity Launch: PendingIntent BAL 정책 준수

Summary by CodeRabbit

  • New Features
    • Edge-to-edge UI across key screens with transparent navigation bar and display cutout support.
    • More reliable background operation via location-classified foreground service and safer notifications.
    • Stronger network security with modern TLS defaults.
    • OS-specific permission handling on newer Android versions (media, notifications, exact alarms, foreground services).
  • Chores
    • Updated compile/target SDK to Android 35.

@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Updates project to SDK 35, refines AndroidManifest permissions and service export status, introduces edge-to-edge utilities and applies them across activities, adds safe foreground service and PendingIntent helpers, centralizes secure OkHttp client creation, adjusts theme for edge-to-edge, and adds a Gradle suppression for compileSdk 35.

Changes

Cohort / File(s) Summary
SDK level and Gradle config
app/build.gradle, gradle.properties		 Bumps compileSdk/targetSdk to 35; adds android.suppressUnsupportedCompileSdk=35.
Manifest and service declaration
app/src/main/AndroidManifest.xml		 Adds versioned/media permissions, POST_NOTIFICATIONS (33+), SCHEDULE_EXACT_ALARM (31+), AD_ID, FOREGROUND_SERVICE/FOREGROUND_SERVICE_LOCATION; sets TimerService to exported="false" with foregroundServiceType="location".
Edge-to-edge utilities and usage
app/src/main/java/com/runnect/runnect/util/EdgeToEdgeUtil.kt, app/src/main/res/values/themes.xml, app/src/main/java/com/runnect/runnect/binding/BindingActivity.kt, app/src/main/java/com/runnect/runnect/presentation/composesample/ComposeSampleActivity.kt, app/src/main/java/com/runnect/runnect/presentation/scheme/SchemeActivity.kt, app/src/main/java/com/runnect/runnect/presentation/splash/SplashActivity.kt		 Adds EdgeToEdgeUtil and theme attributes for transparent system bars and cutout mode; calls edge-to-edge setup in multiple activities (Binding/ComposeSample/Scheme/Splash).
Foreground service safety helpers
app/src/main/java/com/runnect/runnect/presentation/run/TimerService.kt, app/src/main/java/com/runnect/runnect/util/ForegroundServiceUtil.kt, app/src/main/java/com/runnect/runnect/util/IntentUtil.kt		 Replaces direct PendingIntent and startForeground with safe wrappers; adds ForegroundServiceUtil.startForegroundSafely and IntentUtil.createSafePendingIntent.
Networking security centralization
app/src/main/java/com/runnect/runnect/di/RetrofitModule.kt, app/src/main/java/com/runnect/runnect/util/NetworkSecurityUtil.kt		 Introduces NetworkSecurityUtil.createSecureOkHttpClient; Retrofit module now builds clients from this secure builder.
Minor formatting
app/src/main/java/com/runnect/runnect/presentation/MainActivity.kt		 Inserts an empty line after super.onCreate(...); no functional changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as User
  participant TimerService as TimerService
  participant IntentUtil as IntentUtil
  participant ForegroundServiceUtil as ForegroundServiceUtil
  note over TimerService: onStartCommand

  TimerService->>IntentUtil: createSafePendingIntent(context, requestCode, intent, flags, isMutable=false)
  IntentUtil-->>TimerService: PendingIntent

  note over TimerService: Build Notification with PendingIntent

  TimerService->>ForegroundServiceUtil: startForegroundSafely(service, id, notification, LOCATION)
  alt API >= 29
    ForegroundServiceUtil-->>TimerService: startForeground(id, notif, type)
  else API < 29
    ForegroundServiceUtil-->>TimerService: startForeground(id, notif)
  end

  note over TimerService: Service runs as location FGS (non-exported)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

A rabbit taps the SDK to thirty-five,
Hops through insets—edges come alive.
Foreground drums beat safe and bright,
Pending dreams sealed snug and tight.
TLS burrows deep and clean,
Manifests trimmed, secure, serene.
Thump-thump—release is lean! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5aaeb78 and 0d15a09.

📒 Files selected for processing (15)
  • app/build.gradle (1 hunks)
  • app/src/main/AndroidManifest.xml (2 hunks)
  • app/src/main/java/com/runnect/runnect/binding/BindingActivity.kt (2 hunks)
  • app/src/main/java/com/runnect/runnect/di/RetrofitModule.kt (3 hunks)
  • app/src/main/java/com/runnect/runnect/presentation/MainActivity.kt (1 hunks)
  • app/src/main/java/com/runnect/runnect/presentation/composesample/ComposeSampleActivity.kt (2 hunks)
  • app/src/main/java/com/runnect/runnect/presentation/run/TimerService.kt (3 hunks)
  • app/src/main/java/com/runnect/runnect/presentation/scheme/SchemeActivity.kt (2 hunks)
  • app/src/main/java/com/runnect/runnect/presentation/splash/SplashActivity.kt (2 hunks)
  • app/src/main/java/com/runnect/runnect/util/EdgeToEdgeUtil.kt (1 hunks)
  • app/src/main/java/com/runnect/runnect/util/ForegroundServiceUtil.kt (1 hunks)
  • app/src/main/java/com/runnect/runnect/util/IntentUtil.kt (1 hunks)
  • app/src/main/java/com/runnect/runnect/util/NetworkSecurityUtil.kt (1 hunks)
  • app/src/main/res/values/themes.xml (1 hunks)
  • gradle.properties (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/target-sdk-34-35

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@unam98 unam98 merged commit 6c330d6 into develop Aug 25, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unam98